Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
nventuro created a review comment on a pull request on AztecProtocol/aztec-packages
Actually, do we need `compute_preaddress` in the first place? I'd just get rid of it and keep the inlined version here.
nventuro created a review comment on a pull request on AztecProtocol/aztec-packages
Ideally we'd just return this from the wallet in one go, it makes no sense to fetch the components to then produce the secret whenever we need it.
nventuro created a review comment on a pull request on AztecProtocol/aztec-packages
The same thing happens here etc
nventuro created a review comment on a pull request on AztecProtocol/aztec-packages
Is there ever a point in computing the point from preaddr + ivpk? We only use the point when encrpyting for someone, but that's done by going backwards from their addr. I don't see where we'd ever ...
nventuro created a review comment on a pull request on AztecProtocol/aztec-packages
```suggestion // TLDR; P1 = (h + ivsk) * G ```
nventuro created a review comment on a pull request on AztecProtocol/aztec-packages
```suggestion // Given h (our preaddress) and our ivsk, we have two different addressSecret candidates. One encodes to a point with a positive y-coordinate ```
nventuro created a review comment on a pull request on AztecProtocol/aztec-packages
```suggestion // Given h (our preaddress) and our ivpk_m, we can derive our address point. ``` Sounds like the preaddress is a separate thing otherwise
nventuro created a review comment on a pull request on AztecProtocol/aztec-packages
This is missing the `y > half_range` check, and the fact that we only take the x coord
nventuro created a review comment on a pull request on AztecProtocol/aztec-packages
The 0..12 is a bit too magical - and why do we need to pass the original keys?
nventuro created a review comment on a pull request on AztecProtocol/aztec-packages
There should either be a comment or at least conveyed through the name that this value is autogenerated by a TS script.
nventuro created a review comment on a pull request on AztecProtocol/aztec-packages
From the comments in https://github.com/AztecProtocol/aztec-packages/issues/8966 it seemed like we needed to do `addr = -addr` if the y coordinate was high - does that not affect the x coord?
nventuro created a review comment on a pull request on AztecProtocol/aztec-packages
```suggestion let pre_address = self.compute_preaddress(); ```
nventuro created a review comment on a pull request on AztecProtocol/aztec-packages
I found these comments a bit confusing, since it's not clear why the code is commented out - it seems like it was maybe forgotten about. Given we're not handling any of this now, I'd just remove...
nventuro created a review comment on a pull request on AztecProtocol/aztec-packages
I'd do `let x = self.inner` and mention that this is how an address is computed.
AztecBot opened a pull request on AztecProtocol/aztec-packages
chore(master): Release 0.60.1
robot: I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.60.1</summary> ## [0.60.1](https://github.com/AztecProtocol/aztec-packages/compare/aztec-package-v0.60.0...az...
AztecBot pushed 1 commit to release-please--branches--master AztecProtocol/aztec-packages
- chore(master): Release 0.60.1 dc4fa18
ludamad pushed 1 commit to master AztecProtocol/aztec-packages
- chore: have 'aztec' honour the 'DEBUG' env var (#9413) 771a2ac
ludamad closed a pull request on AztecProtocol/aztec-packages
chore: have 'aztec' honour the 'DEBUG' env var
stevenplatt pushed 1 commit to srp/16-validator-xfer-test AztecProtocol/aztec-packages
- more robust slot time edit with error checking. c4ae146
AztecBot created a comment on a pull request on AztecProtocol/aztec-packages
robot: Release is at https://github.com/AztecProtocol/aztec-packages/releases/tag/barretenberg-v0.60.0 :sunflower:
AztecBot published a release on AztecProtocol/aztec-packages
barretenberg: v0.60.0
## [0.60.0](https://github.com/AztecProtocol/aztec-packages/compare/barretenberg-v0.59.0...barretenberg-v0.60.0) (2024-10-24) ### ⚠ BREAKING CHANGES * replace usage of vector in keccakf1600 inpu...
AztecBot created a comment on a pull request on AztecProtocol/aztec-packages
robot: Release is at https://github.com/AztecProtocol/aztec-packages/releases/tag/barretenberg.js-v0.60.0 :sunflower:
AztecBot created a comment on a pull request on AztecProtocol/aztec-packages
robot: Release is at https://github.com/AztecProtocol/aztec-packages/releases/tag/aztec-package-v0.60.0 :sunflower:
AztecBot published a release on AztecProtocol/aztec-packages
barretenberg.js: v0.60.0
## [0.60.0](https://github.com/AztecProtocol/aztec-packages/compare/barretenberg.js-v0.59.0...barretenberg.js-v0.60.0) (2024-10-24) ### Features * Eccvm translator zk sumcheck ([#9199](https://g...