Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
LeilaWang created a review comment on a pull request on AztecProtocol/aztec-packages
I checked the codebase again and PublicKeys is never included in a struct that can be empty. So agree with you that it's a footgun! Then maybe remove `is_empty` and the if statement in `hash`, to a...
AztecBot pushed 2 commits to release-please--branches--master AztecProtocol/aztec-packages
catmcgee closed an issue on AztecProtocol/aztec-packages
bug: fix dead "milestones overview" link
The Readme file has this link which opens up to a dead page. I went through the 25 pages of open issues and there's none on it <img width="1198" alt="Screenshot 2024-06-04 at 12 57 26 PM" src="h...
catmcgee closed an issue on AztecProtocol/aztec-packages
bug: fix dead "milestones overview" link
The Readme file has this link which opens up to a dead page. I went through the 25 pages of open issues and there's none on it <img width="1198" alt="Screenshot 2024-06-04 at 12 57 26 PM" src="h...
catmcgee pushed 1 commit to master AztecProtocol/aztec-packages
- feat(docs): nits (#8948) Closes https://github.com/AztecProtocol/dev-rel/issues/410 closes: https://github.com/Azte... 008fdd1
catmcgee closed a pull request on AztecProtocol/aztec-packages
feat(docs): nits
Closes https://github.com/AztecProtocol/dev-rel/issues/410 closes: https://github.com/AztecProtocol/aztec-packages/issues/6864 closes: https://github.com/AztecProtocol/dev-rel/issues/417 Pleas...
catmcgee pushed 1 commit to docs/function-transforms AztecProtocol/aztec-packages
- broken link 0a8a99e
dbanks12 created a review comment on a pull request on AztecProtocol/aztec-packages
I was wondering the same thing!
dbanks12 created a review comment on a pull request on AztecProtocol/aztec-packages
Okay, I like that. Simplifies things.
jeanmon pushed 1 commit to jm/9349-avm-shplemini AztecProtocol/aztec-packages
- 9349: Adapt proof length formula in codegen template file 801e09c
dbanks12 created a review comment on a pull request on AztecProtocol/aztec-packages
Ah good catch, did not mean to leave this in.
dbanks12 created a review comment on a pull request on AztecProtocol/aztec-packages
Ah I love the ternary operator :rofl: probably comes from spending too much time in React.
LeilaWang created a review on a pull request on AztecProtocol/aztec-packages
LGTM! And thanks for fixing the constants code gen :)
github-actions[bot] created a comment on a pull request on AztecProtocol/aztec-packages
# Changes to public function bytecode sizes > Generated at commit: [d6b623606fee0b5b5805941f748632b55dbf1415](/AztecProtocol/aztec-packages/commit/d6b623606fee0b5b5805941f748632b55dbf1415), compar...
LeilaWang created a review comment on a pull request on AztecProtocol/aztec-packages
Maybe it's worth keeping the "empty" PublicKeys implementation. It can be used in places where the address doesn't have to be derived, so that when calling hash on it, it will go into this if state...
spypsy pushed 1 commit to spy/remove-e2e-earthfile AztecProtocol/aztec-packages
- remove test logging fa323b2
maramihali created a review comment on a pull request on AztecProtocol/aztec-packages
if yes, will you please add a comment?
maramihali created a review comment on a pull request on AztecProtocol/aztec-packages
actually fun fact the labels don't matter for anything other than debugging
maramihali created a review comment on a pull request on AztecProtocol/aztec-packages
Maybe it would be good to exemplify what you mean here to help the reader
maramihali created a review comment on a pull request on AztecProtocol/aztec-packages
this is only if we do something smarter than generating a circuit_size random polynomials.
IlyasRidhuan created a review comment on a pull request on AztecProtocol/aztec-packages
yeah that also works
