Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
dbanks12 created a review comment on a pull request on AztecProtocol/aztec-packages
Ah I love the ternary operator :rofl: probably comes from spending too much time in React.
LeilaWang created a review on a pull request on AztecProtocol/aztec-packages
LGTM! And thanks for fixing the constants code gen :)
github-actions[bot] created a comment on a pull request on AztecProtocol/aztec-packages
# Changes to public function bytecode sizes > Generated at commit: [d6b623606fee0b5b5805941f748632b55dbf1415](/AztecProtocol/aztec-packages/commit/d6b623606fee0b5b5805941f748632b55dbf1415), compar...
LeilaWang created a review comment on a pull request on AztecProtocol/aztec-packages
Maybe it's worth keeping the "empty" PublicKeys implementation. It can be used in places where the address doesn't have to be derived, so that when calling hash on it, it will go into this if state...
spypsy pushed 1 commit to spy/remove-e2e-earthfile AztecProtocol/aztec-packages
- remove test logging fa323b2
maramihali created a review comment on a pull request on AztecProtocol/aztec-packages
if yes, will you please add a comment?
maramihali created a review comment on a pull request on AztecProtocol/aztec-packages
actually fun fact the labels don't matter for anything other than debugging
maramihali created a review comment on a pull request on AztecProtocol/aztec-packages
Maybe it would be good to exemplify what you mean here to help the reader
maramihali created a review comment on a pull request on AztecProtocol/aztec-packages
this is only if we do something smarter than generating a circuit_size random polynomials.
IlyasRidhuan created a review comment on a pull request on AztecProtocol/aztec-packages
yeah that also works
Maddiaa0 pushed 118 commits to md/serde-for-signed-ints AztecProtocol/aztec-packages
- fix: Revert "fix: Revert "feat: use s3 cache in bootstrap fast"" (#9182) Reverts AztecProtocol/aztec-packages#9181 ... ce3d08a
- feat(avm): codegen recursive_verifier.cpp (#9204) Resolves #8849 2592e50
- feat: Tracy time with instrumentation (#9170) At scripts for profiling locally with tracy and samply, add instrumen... 1c008d9
- git subrepo push --branch=master barretenberg subrepo: subdir: "barretenberg" merged: "e87802c06a" upstream:... 4542f1d
- chore: replace relative paths to noir-protocol-circuits b787722
- git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] acc05a6
- git subrepo push --branch=master noir-projects/aztec-nr subrepo: subdir: "noir-projects/aztec-nr" merged: "0... e8065a2
- fix: mac-build (#9216) fix mac build issues with emplace back 80ea32c
- chore: disable flakey rediscovery.test.ts (#9217) 14e73e2
- git subrepo push --branch=master barretenberg subrepo: subdir: "barretenberg" merged: "14969f58de" upstream:... 08b6789
- chore: replace relative paths to noir-protocol-circuits 7934d39
- git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] 116fe90
- git subrepo push --branch=master noir-projects/aztec-nr subrepo: subdir: "noir-projects/aztec-nr" merged: "d... 9656fbf
- chore(ci): try to offload compute burden when merging (#9213) We are going to ramp up what we test on master, and we... c8dc016
- feat: externally accessible spartan deployment (#9171) Update the aztec-network helm chart to be accessible by exter... 26edb4d
- chore: disable e2e-p2p completely (#9219) she flakes again disabled until https://github.com/AztecProtocol/aztec... 286d617
- fix: prometheus metrics (#9226) Prometheus/otel demand that these metric names be unique, so when we're generic ove... 9445a4f
- fix: publish-aztec-packages.yml (#9229) It had stability issues and should not use people's runners Closes #9220 4bfeb83
- chore: offsite network stuff (#9231) - turn down transaction bot - add ability to remove l1 validator from CLI - a... 155b40b
- fix: buffer instanceof usage (#9235) Closes https://github.com/AztecProtocol/aztec-packages/issues/5782 8e66ef9
- and 98 more ...
IlyasRidhuan created a review comment on a pull request on AztecProtocol/aztec-packages
hmm no i think this will break - you might want to call this with the default public keys
jeanmon created a review comment on a pull request on AztecProtocol/aztec-packages
This comment is obsolete as we have already integrated the public inputs.
jeanmon pushed 7 commits to jm/9349-avm-shplemini AztecProtocol/aztec-packages
- chore: unstake the bond when the proof lands (#9363) If you claimed it, and the proof lands (from anyone) your bond ... b25b913
- Rebase on master and run codegen d10389d
- 9349: migrate zeromorph to shplemini in AVM e737778
- 9349: remove occurences of zeromorph 37fd6e4
- 9349: adapt proof length 50dd573
- 9349: rebase on master 42af344
- 9349: Transcript serialization 2621970
maramihali created a review comment on a pull request on AztecProtocol/aztec-packages
I think we shouldn't use `from_witness` here since the default_commitment_val is a constant (also above)
maramihali created a review comment on a pull request on AztecProtocol/aztec-packages
Not something that is a priority now but I wonder whether the `*_exists` variables shouldn't be bool_t and the `kernel_return_data_commitment` be set via conditional assigns.
maramihali created a review on a pull request on AztecProtocol/aztec-packages
Mostly looks good - added a questions and some thoughts on the stdlib code
maramihali created a review on a pull request on AztecProtocol/aztec-packages
Mostly looks good - added a questions and some thoughts on the stdlib code
fcarreiro created a review comment on a pull request on AztecProtocol/aztec-packages
Why not do `j = num_rows; j > 0; --j` ? Then you can just use `j` for everything if I see correctly
