Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
The backwards compatibility is to handle file.path being '/allen' or the updated version where file.path = cloud path. I thought that we were fully past that after the new file rebuild, hence tryin...
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
Not sure what the comment is here but my interpretation is this format allows us to create our own annotations in BFF which we later propagate with the file properties.
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
removed in [3bee712](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/3bee712c637ad2bf7571bed19b960fe11de85598)
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
Not any more.... removed in [3bee712](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/3bee712c637ad2bf7571bed19b960fe11de85598)
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
I made getLocalPath as a function in [3bee712](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/3bee712c637ad2bf7571bed19b960fe11de85598). However I left get localPath where it cal...
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
Yep!, adding the Environment adds an indent that GitHub doesn't like.
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
resolved by removing in [3bee712](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/3bee712c637ad2bf7571bed19b960fe11de85598)
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
Resolved by deriving from cloud path in [3bee712](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/3bee712c637ad2bf7571bed19b960fe11de85598)
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
Resolved by removing in [3bee712](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/3bee712c637ad2bf7571bed19b960fe11de85598)
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
resolved in [3bee712](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/3bee712c637ad2bf7571bed19b960fe11de85598)
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
Resolved by removing in [3bee712](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/3bee712c637ad2bf7571bed19b960fe11de85598)
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
Resolved by deriving from cloud path in [3bee712](https://github.com/AllenInstitute/biofile-finder/pull/389/commits/3bee712c637ad2bf7571bed19b960fe11de85598)
BrianWhitneyAI pushed 1 commit to feature/derive_local_path AllenInstitute/biofile-finder
- derive path from cloudpath 3bee712
hughes036 created a review on a pull request on AllenInstitute/biofile-finder
See questions about backward compatibility. Lgtm otherwise.
hughes036 created a review comment on a pull request on AllenInstitute/biofile-finder
has unit test cov?
hughes036 created a review comment on a pull request on AllenInstitute/biofile-finder
We still need backward compatibility - should this change (and the block below) use the new heuristic `this.getAnnotation("Cache Eviction Date")`?
hughes036 created a review comment on a pull request on AllenInstitute/biofile-finder
less custom code to test FTW