Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
BrianWhitneyAI pushed 1 commit to feature/move-files-styling AllenInstitute/biofile-finder
- remove NAS wording efccc6c
pgarrison created a review comment on a pull request on AllenInstitute/biofile-finder
Local path must exist because there is an annotation with the name Local File Path (line 81): if a file is not present on the Vast, there is no Local File Path annotation.
pgarrison created a review comment on a pull request on AllenInstitute/biofile-finder
Resolved in [66f572c](https://github.com/AllenInstitute/biofile-finder/pull/375/commits/66f572c2f0f8bc49b926c514dc270a587bc3f334)
pgarrison created a review comment on a pull request on AllenInstitute/biofile-finder
Resolved in [8817332](https://github.com/AllenInstitute/biofile-finder/pull/375/commits/88173323832b26611f456ca2a1aaf2638264255f)
pgarrison pushed 2 commits to feature/367-canonical-path-is-cloud AllenInstitute/biofile-finder
pgarrison created a comment on a pull request on AllenInstitute/biofile-finder
> @pgarrison If we are specifically calling out VAST in the "Copy files to local NAS (VAST)" modal @BrianWhitneyAI was working on, perhaps we should be consistent and mention VAST here? Without pot...
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
This is a pattern used by all the http service methods that made sense to me before but which I'm now having trouble defending. My interpretation is that when axios rejects a call, it does not nece...
lynwilhelm created a comment on a pull request on AllenInstitute/biofile-finder
@pgarrison If we are specifically calling out VAST in the "Copy files to local NAS (VAST)" modal @BrianWhitneyAI was working on, perhaps we should be consistent and mention VAST here? Without poten...
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
I'm not the author of this one so I may not have the right explanation, but I think it's a method of throwing custom error messages in chai?
aswallace created a review comment on a pull request on AllenInstitute/biofile-finder
Yes, this is for the status message component. The modal z-index is set by fluent, not us, so this comment is intended to note that the status message will be covered by the modal overlay. I can cl...
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
agree with comment
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
could add the specific metadata name 'file_path' here
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
if the default already rejects why is this a condition?
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
Could you have a valid response with no data?
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
I think this is redundant?
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
it might be better to aggregate all missing annotations and throw a single error
BrianWhitneyAI created a review comment on a pull request on AllenInstitute/biofile-finder
Is this comment right seems like 1000 not 1000000?
pgarrison opened a pull request on AllenInstitute/biofile-finder
367 Remove Canonical path and format Cloud path
# Purpose With the new cloud-first FMS backend features, the `file_path` from FMS is a cloud path like `staging.files.allencell.org/c18/726/e93/ea3/804/468/34d/873/d6c/435/c6/aicsfiles-test-8c85cf...