Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
codecov[bot] created a comment on a pull request on AY2425S1-CS2103T-T09-1/tp
## [Codecov](https://app.codecov.io/gh/AY2425S1-CS2103T-T09-1/tp/pull/67?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=A...
uniqly opened a pull request on AY2425S1-CS2103T-T09-1/tp
Add application list to `Company` and update storage
Resolves #57 and #64
uniqly created a review comment on a pull request on AY2425S1-CS2103T-T09-1/tp
I think a static method / constant would be more appropriate.
uniqly created a review comment on a pull request on AY2425S1-CS2103T-T09-1/tp
I think adding `applications` to the constructor would be appropriate in this case since `tags` is also in the constructor.
uniqly created a review comment on a pull request on AY2425S1-CS2103T-T09-1/tp
I don't think we should edit the company instance directly to be consistent with the immutable classes.
uniqly created a review comment on a pull request on AY2425S1-CS2103T-T09-1/tp
See suggested change for `Company#addApplication()`
uniqly created a review comment on a pull request on AY2425S1-CS2103T-T09-1/tp
I think this should return a copy of the original application with the new application appended and status changed. (see `EditCommand.EditCompanyDescriptor` for reference)
uniqly created a review on a pull request on AY2425S1-CS2103T-T09-1/tp
Suggestion: To add a `ApplyComapanyDescriptor` class to `ApplyCommand.java` similar to `EditCommand.java`
uniqly created a review on a pull request on AY2425S1-CS2103T-T09-1/tp
Suggestion: To add a `ApplyComapanyDescriptor` class to `ApplyCommand.java` similar to `EditCommand.java`
codecov[bot] created a comment on a pull request on AY2425S1-CS2103T-T09-1/tp
## [Codecov](https://app.codecov.io/gh/AY2425S1-CS2103T-T09-1/tp/pull/59?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=A...
codecov[bot] created a comment on a pull request on AY2425S1-CS2103T-T09-1/tp
## [Codecov](https://app.codecov.io/gh/AY2425S1-CS2103T-T09-1/tp/pull/66?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=A...
blanklogic opened a pull request on AY2425S1-CS2103T-T09-1/tp
Add initial implementation of Apply Command
Resolves #60 and #63 ## Changes - Initial Implementation of Apply Command using ```java apply INDEX n/NAME d/DESCRIPTION apply 1 n/Full Stack Engineer d/Requires ReactJS and ExpressJS ``` ...
github-actions[bot] pushed 1 commit to gh-pages AY2425S1-CS2103T-T09-1/tp
- deploy: 4decab81a808810e30301b695ab7a71197e414b5 9f5812f
blanklogic pushed 3 commits to master AY2425S1-CS2103T-T09-1/tp
blanklogic closed a pull request on AY2425S1-CS2103T-T09-1/tp
Add application class
Important info for Application class: Fields: - description - status Methods: - setAppStatus Other classes added: - Description - AppStatus closes #56
blanklogic created a review on a pull request on AY2425S1-CS2103T-T09-1/tp
LGTM! Will be dealing with the minor nits mentioned by @uniqly in a separate PR.
uniqly opened an issue on AY2425S1-CS2103T-T09-1/tp
Gracefully handle optional inputs
Currently we are using a "hotfix" solution to handle optional inputs for the the `add` command. (See #58) For instance, if the user decides not to include a phone number in the `add` command, a ...
uniqly created a review comment on a pull request on AY2425S1-CS2103T-T09-1/tp
Minor nit: I think using different test strings (like: "DevOps Intern" or "Database Engineer", etc.) for the description to simulate a real application could be more appropriate.
uniqly created a review on a pull request on AY2425S1-CS2103T-T09-1/tp
LGTM! Except some minor nits. 😄
uniqly created a review on a pull request on AY2425S1-CS2103T-T09-1/tp
LGTM! Except some minor nits. 😄
Shux347 opened an issue on AY2425S1-CS2103T-T09-1/tp
Add Company status change logic
When a new application is created for a company that is not "APPLIED" status, change status to "APPLIED"
Shux347 created a comment on an issue on AY2425S1-CS2103T-T09-1/tp
Will require changes in UI as well as have a new field in company class to track the number of open applications