Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
OrangeCatLoves created a review comment on a pull request on AY2425S1-CS2103T-F10-3/tp
LGTM!
OrangeCatLoves created a review comment on a pull request on AY2425S1-CS2103T-F10-3/tp
LGTM!
Potatoad88 created a review on a pull request on AY2425S1-CS2103T-F10-3/tp
LGTM but I think your other PR contains code from this PR as well? DId you create a branch from your branch instead of your master?
Potatoad88 created a review comment on a pull request on AY2425S1-CS2103T-F10-3/tp
Should this tescase be deleted if not in use?
Potatoad88 created a review comment on a pull request on AY2425S1-CS2103T-F10-3/tp
Should it be 'wants to buy' instead of 'has to be bought'? Because just because he adds the property doesn't mean he is guaranteed to buy it but rather he is just interested in it?
Potatoad88 created a review on a pull request on AY2425S1-CS2103T-F10-3/tp
LGTM but I think in the future you can split it into different PRs for different features. For example separating the pin and findtc feature into 2 PRs
github-actions[bot] pushed 1 commit to gh-pages AY2425S1-CS2103T-F10-3/tp
- deploy: 7daa11ab6d42cc073ecf5ad2fe60b1884114f97c bc8f4a4
codecov[bot] created a comment on a pull request on AY2425S1-CS2103T-F10-3/tp
## [Codecov](https://app.codecov.io/gh/AY2425S1-CS2103T-F10-3/tp/pull/122?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=...
codecov[bot] created a comment on a pull request on AY2425S1-CS2103T-F10-3/tp
## [Codecov](https://app.codecov.io/gh/AY2425S1-CS2103T-F10-3/tp/pull/108?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=...
codecov[bot] created a comment on a pull request on AY2425S1-CS2103T-F10-3/tp
## [Codecov](https://app.codecov.io/gh/AY2425S1-CS2103T-F10-3/tp/pull/117?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=...
triishaa created a review on a pull request on AY2425S1-CS2103T-F10-3/tp
Shouldn't use * imports. Can it be a potential violation of coding standards?
triishaa created a review on a pull request on AY2425S1-CS2103T-F10-3/tp
Update the documentation in BoughtPropertyCommandParser class. Its currently w.r.t the AddPropertyToBuyCommand
triishaa created a review on a pull request on AY2425S1-CS2103T-F10-3/tp
Update the documentation in BoughPropertyCommandParser class. Its currently w.r.t the AddPropertyToBuyCommand
triishaa created a review on a pull request on AY2425S1-CS2103T-F10-3/tp
The English in the documentation can be improved. Maybe use "Formats the {@code Properties} to be displayed to the user"
triishaa created a review on a pull request on AY2425S1-CS2103T-F10-3/tp
Should we use Props as short form for property? Can it be a potential bug?
ITZXITZX opened a pull request on AY2425S1-CS2103T-F10-3/tp
Implement bought and sold command
Work In Progress. Have only updated implementation of bought command and statistics class in AddressBook. Yet to implement test cases and the sold commandgithub-actions[bot] pushed 1 commit to gh-pages AY2425S1-CS2103T-F10-3/tp
- deploy: c527977f4eafd89f568154cd97d96515af06e69c 6ac73c2