Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

AY2425S1-CS2103T-F08-2/tp

PrishaVP opened a pull request on AY2425S1-CS2103T-F08-2/tp
Fix delete parse message
PrishaVP pushed 6 commits to master AY2425S1-CS2103T-F08-2/tp
  • Add export feature f74b734
  • Fix bugs in tests 6159d93
  • Update src/main/java/seedu/address/logic/commands/ExportCommand.java Co-authored-by: Sanchita Dhareshwar <81695359+s... 67b7c9f
  • Update src/main/java/seedu/address/logic/commands/ExportCommand.java Co-authored-by: Sanchita Dhareshwar <81695359+s... 7d199c5
  • Fix messages in list command 7eeffd0
  • Merge pull request #106 from PrishaVP/Alpha-version---export- Alpha version - Add export feature f710dff

View on GitHub

PrishaVP closed an issue on AY2425S1-CS2103T-F08-2/tp
Alpha version - Export emails
PrishaVP closed a pull request on AY2425S1-CS2103T-F08-2/tp
Alpha version - Add export feature
fixes #97
PrishaVP created a comment on a pull request on AY2425S1-CS2103T-F08-2/tp
Can consider changing all occurrences of tag to studyGroupTag or something like that. Also I think you should look through EditCommandParserTest to see if you need to make any changes. For example,...

View on GitHub

sannie-beep created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
Ok, LGTM!

View on GitHub

sannie-beep created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
Just two nits with the error messages

View on GitHub

sannie-beep created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
```suggestion public static final String FILE_WRITE_ERROR = "Unable to export participants' emails due to unexpected I/O error"; ```

View on GitHub

sannie-beep created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
```suggestion "Unable to export participants' emails due to denied export file access"; ```

View on GitHub

sannie-beep created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
Just a few nits with the error messages

View on GitHub

sannie-beep created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
Just a few nits with the error messages

View on GitHub

k-hian pushed 2 commits to master AY2425S1-CS2103T-F08-2/tp
  • PUML: export puml as images Fix syntax error in BetterModelClassDiagram.puml. fd71c3b
  • Merge pull request #105 from k-hian/branch-PUML AlphaVersion - Export puml as images a4e8cf0

View on GitHub

k-hian closed an issue on AY2425S1-CS2103T-F08-2/tp
PUML - Export puml as images for DG
k-hian created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
This seems to be an issue with my PlantUML renderer. The puml file is correct, but it seems that the renderer isn't able to render the multiplicity on the left and right side of the arrow respectiv...

View on GitHub

k-hian created a review on a pull request on AY2425S1-CS2103T-F08-2/tp

View on GitHub

sannie-beep opened a pull request on AY2425S1-CS2103T-F08-2/tp
Alpha version - Edit: remove tags
fixes #85
wkxcass closed an issue on AY2425S1-CS2103T-F08-2/tp
Alpha version - Code standardization (miscellaneous)
- Tweak Javadoc comments to ensure alignment with current project. - Tweak formats to ensure consistency with previously standardized messages.
wkxcass pushed 4 commits to master AY2425S1-CS2103T-F08-2/tp
  • Code standardization (comments and messages) 73c7149
  • Fix bug in Name validation 77dfc79
  • Update src/main/java/seedu/address/model/person/Name.java Co-authored-by: k-hian <[email protected]... 21ecda4
  • Merge pull request #102 from wkxcass/branch-CodeStandardization Alpha version - Code standardization (miscellaneous) 6ca4d6d

View on GitHub

wkxcass closed a pull request on AY2425S1-CS2103T-F08-2/tp
Alpha version - Code standardization (miscellaneous)
Fixes #101 - Tweak Javadoc comments to ensure alignment with current project. - Tweak formats to ensure consistency with previously standardized messages.
sannie-beep created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
Tested, LGTM !

View on GitHub

k-hian created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
```suggestion public static final String VALIDATION_REGEX = "([a-zA-Z]+ )+[a-zA-Z]+"; ```

View on GitHub

k-hian created a review on a pull request on AY2425S1-CS2103T-F08-2/tp

View on GitHub

k-hian created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
Also @sannie-beep pointed out that this regex prevents double space, I think the observation is slightly wrong. Yes this does prevent double space, but only after the first word. ![](https://gith...

View on GitHub

k-hian created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
Shouldn't the regex be `[a-zA-Z]` with the last 'Z' as capital?

View on GitHub

k-hian created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
Please take a look at the regex as I think there is some problem with it.

View on GitHub

k-hian created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
Please take a look at the regex as I think there is some problem with it.

View on GitHub

k-hian created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
I think the reason it works is because the name is trimmed by the ParserUtil. I guess in this case, function-wise it doesn't matter as much which regex validation we use, but on a developer-as-main...

View on GitHub

Load more