Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
sannie-beep created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
```suggestion "Unable to export participants' emails due to denied export file access"; ```
sannie-beep created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
Just a few nits with the error messages
sannie-beep created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
Just a few nits with the error messages
k-hian opened a pull request on AY2425S1-CS2103T-F08-2/tp
DG - Add find command implementation details
k-hian closed an issue on AY2425S1-CS2103T-F08-2/tp
PUML - Syntax error in BetterModelClassDiagram.puml
k-hian pushed 2 commits to master AY2425S1-CS2103T-F08-2/tp
k-hian created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
This seems to be an issue with my PlantUML renderer. The puml file is correct, but it seems that the renderer isn't able to render the multiplicity on the left and right side of the arrow respectiv...
sannie-beep opened a pull request on AY2425S1-CS2103T-F08-2/tp
Alpha version - Edit: remove tags
fixes #85
wkxcass closed an issue on AY2425S1-CS2103T-F08-2/tp
Alpha version - Code standardization (miscellaneous)
- Tweak Javadoc comments to ensure alignment with current project. - Tweak formats to ensure consistency with previously standardized messages.
wkxcass pushed 4 commits to master AY2425S1-CS2103T-F08-2/tp
- Code standardization (comments and messages) 73c7149
- Fix bug in Name validation 77dfc79
- Update src/main/java/seedu/address/model/person/Name.java Co-authored-by: k-hian <[email protected]... 21ecda4
- Merge pull request #102 from wkxcass/branch-CodeStandardization Alpha version - Code standardization (miscellaneous) 6ca4d6d
wkxcass closed a pull request on AY2425S1-CS2103T-F08-2/tp
Alpha version - Code standardization (miscellaneous)
Fixes #101 - Tweak Javadoc comments to ensure alignment with current project. - Tweak formats to ensure consistency with previously standardized messages.
k-hian created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
```suggestion public static final String VALIDATION_REGEX = "([a-zA-Z]+ )+[a-zA-Z]+"; ```
k-hian created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
Also @sannie-beep pointed out that this regex prevents double space, I think the observation is slightly wrong. Yes this does prevent double space, but only after the first word. ![](https://gith...
k-hian created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
Shouldn't the regex be `[a-zA-Z]` with the last 'Z' as capital?
k-hian created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
Please take a look at the regex as I think there is some problem with it.
k-hian created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
Please take a look at the regex as I think there is some problem with it.
k-hian created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
I think the reason it works is because the name is trimmed by the ParserUtil. I guess in this case, function-wise it doesn't matter as much which regex validation we use, but on a developer-as-main...
sannie-beep created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
The "filtered" and "all" labels seem to be swapped in the new version. Is this intentional? Because it seems that in the ModelManager class, it does have a filtered list.
sannie-beep created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
Strange because in the puml in my version the labels aren't swapped 🤔 
sannie-beep created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
Yeah, just this small issue.
sannie-beep created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
Yeah, just this small issue.
sannie-beep created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
Oh wait I think I see the issue here! Cassandra's tweak allows double spacing between the first name and surname. So the real issue is that the version without the additional regex accepts `n/...
sannie-beep created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
@k-hian This is with her edited version: 
sannie-beep created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
Yeah, I think conclusion: keep the original regex, and maybe we can tweak it to only alphabetical, no numeric. Let's see what the rest think too