Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
sannie-beep created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
The "filtered" and "all" labels seem to be swapped in the new version. Is this intentional? Because it seems that in the ModelManager class, it does have a filtered list.
sannie-beep created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
Strange because in the puml in my version the labels aren't swapped 🤔 
sannie-beep created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
Yeah, just this small issue.
sannie-beep created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
Yeah, just this small issue.
sannie-beep created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
Oh wait I think I see the issue here! Cassandra's tweak allows double spacing between the first name and surname. So the real issue is that the version without the additional regex accepts `n/...
sannie-beep created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
@k-hian This is with her edited version: 
sannie-beep created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
Yeah, I think conclusion: keep the original regex, and maybe we can tweak it to only alphabetical, no numeric. Let's see what the rest think too
sannie-beep created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
Yeah, I think conclusion: keep the original regex, and maybe we can tweak it to only alphabetical, no numeric. Let's see what the rest think too
wkxcass created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
@sannie-beep ooh good point there, I'm actually fine with alphabetical! Can't seem to see a need for numbers.. may need others' inputs to decide as well~
wkxcass created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
@k-hian As in, only the previous line with 3 `[\\p{Alnum}]`s can enforce correctly? Or the current one with 2 can as well XD
wkxcass created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
So far yes, I also updated the one in `EditCommand` as well, just that it's under the `edit` PR (merged a few seconds ago)~
wkxcass pushed 3 commits to master AY2425S1-CS2103T-F08-2/tp
wkxcass closed an issue on AY2425S1-CS2103T-F08-2/tp
Alpha version - Message standardization (edit feature)
Tweak formats to ensure consistency with previously standardized messages.
wkxcass closed a pull request on AY2425S1-CS2103T-F08-2/tp
Alpha version - Message standardization (edit feature)
Fixes #99 Tweaked formats to ensure consistency with previously standardized messages.
k-hian opened a pull request on AY2425S1-CS2103T-F08-2/tp
AlphaVersion - Export puml as images
Fixes #104 #103
k-hian opened an issue on AY2425S1-CS2103T-F08-2/tp
PUML - Syntax error in BetterModelClassDiagram.puml
sannie-beep created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
Nice! Do all our messages also follow this ? 🤔
sannie-beep created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
Okay! I tested it, and it seems to work the same, so your edit seems good! Another thing is, do we want the name to be Alphanumerical, or just alphabetical?
k-hian created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
The reason for the extra `[\\p{Alnum}]` is to enforce the "at least two word" rule. Without the extra portion, `Tan ` is an acceptable name.
k-hian created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
Sorry, it seems like the change is made in the other PR. You can ignore this suggestion.
k-hian created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
Could you standardise this language FindCommand (MESSAGE_NO_CRITERIA) as well?