Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
wkxcass closed an issue on AY2425S1-CS2103T-F08-2/tp
MVP - Fix UI bug
Fix bug: study group tags not showing in person cards
wkxcass pushed 2 commits to master AY2425S1-CS2103T-F08-2/tp
wkxcass closed a pull request on AY2425S1-CS2103T-F08-2/tp
MVP - Fix UI bugs
Fixes #72 Study group tags are now displayed properly in person cards.
k-hian created a review on a pull request on AY2425S1-CS2103T-F08-2/tp
LGTM! Thanks for fixing on such short notice.
wkxcass opened an issue on AY2425S1-CS2103T-F08-2/tp
MVP - Fix UI bug
Fix bug: study group tags not showing in person cards
PrishaVP closed an issue on AY2425S1-CS2103T-F08-2/tp
MVP - Save feature (load)
When loading fails due to corrupted file, denied access or other unexpected I/O errors: display corresponding error message (and create new empty address book, which is already implemented). _**re...
PrishaVP pushed 19 commits to master AY2425S1-CS2103T-F08-2/tp
- Add Ui message for load failure and also add new test for saving 9a5ad77
- Update src/test/java/seedu/address/storage/JsonAddressBookStorageTest.java 25391de
- Update src/test/java/seedu/address/storage/JsonAddressBookStorageTest.java 76985a5
- Update src/test/java/seedu/address/storage/JsonAddressBookStorageTest.java d7d1ca3
- Update src/test/java/seedu/address/storage/JsonAddressBookStorageTest.java d77ba35
- Remove test because it doesn't work in the online Gradle d13fb05
- Resolve merge conflict fdb8536
- no message 03ed1c6
- Resolve merge conflict 83a940d
- Update src/test/java/seedu/address/storage/JsonAddressBookStorageTest.java 3ecd202
- Update src/test/java/seedu/address/storage/JsonAddressBookStorageTest.java ed1cd5b
- Fix style aaeba1c
- Fix test file 6cb070b
- Update src/test/data/JsonAddressBookStorageTest/notJsonFormatAddressBook.json 2ab026f
- Update src/main/java/seedu/address/MainApp.java edf8d5a
- Update src/main/java/seedu/address/ui/MainWindow.java d469dc3
- Remove ! from save error messages 4df6adc
- Update src/main/java/seedu/address/MainApp.java 7cbabd4
- Merge pull request #68 from PrishaVP/MVP-Save-feature-(load) Add Ui message for load failure and also add new test f... 6efc11b
PrishaVP closed a pull request on AY2425S1-CS2103T-F08-2/tp
Add Ui message for load failure and also add new test for saving
fixes #59
PrishaVP created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
```suggestion commandResult = new CommandResult("Unable to load contacts due to unexpected data loading error"); ```
PrishaVP created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
```suggestion } ```
k-hian pushed 8 commits to master AY2425S1-CS2103T-F08-2/tp
- Add two word constraint to name Add checks for constraints, and update MESSAGE_CONSTRAINT with information. c148263
- Merge branch 'master' into branch-Message cf66f56
- Standardise message to feature spec aa7b783
- Refactor Tag to StudyGroupTag d84bd82
- Standardise method names for StudyGroupTags 6af6441
- Merge branch 'master' into branch-Message 383192c
- Standardise method name in util package Standardise method names relating to StudyGroupTags. 0d55c79
- Merge pull request #71 from k-hian/branch-Message Standardise message and class names 25905a5
k-hian closed an issue on AY2425S1-CS2103T-F08-2/tp
MVP - Model messages standardisation
Standardise (error) messages across Model to match the new context of model classes. Update any missed AB3 references to RR.
k-hian closed a pull request on AY2425S1-CS2103T-F08-2/tp
Standardise message and class names missed during v1.2
Fixes #55
wkxcass reopened a pull request on AY2425S1-CS2103T-F08-2/tp
Standardise message and class names missed during v1.2
Fixes #55
wkxcass closed a pull request on AY2425S1-CS2103T-F08-2/tp
Standardise message and class names missed during v1.2
Fixes #55
k-hian created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
A lot of the messages do not end with a punctuation (! or .) so I'm inclined to keep it that way for now. It's a small preference decision anyways so if we want we can go back later to standardise ...
wkxcass closed an issue on AY2425S1-CS2103T-F08-2/tp
MVP - Fix bug (add feature)
`Age` should not accept negative integers, including **-0**.
wkxcass created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
```suggestion public static final String MESSAGE_EMPTY = "No saved participants to display!"; ```
wkxcass created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
```suggestion /* * The study group name must be alphanumeric. */ public static final String VALIDATION_REGEX = "\\p{Alnum}+"; ```
wkxcass created a review comment on a pull request on AY2425S1-CS2103T-F08-2/tp
Just a nit: can consider if `getStudyGroupTagSet` would be a better method name, if not can ignore (since it's also quite long)