Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
zi-yii created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
same variable naming issue
zi-yii created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
`expectedInsurancePlansManager` instead of `expectedInsurancePlanManager`, remember to edit the javadoc too 😃
zi-yii created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
`expectedInsurancePlansManager` instead of `expectedInsurancePlanManager`
zi-yii created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
Naming would be better to follow class name. Hence `originalInsurancePlansManager` would be a better name (Note the 's')
zi-yii created a review on a pull request on AY2425S1-CS2103-F12-1/tp
LGTM but requires some changes to variable naming (can ctrl f to check)
zi-yii created a review on a pull request on AY2425S1-CS2103-F12-1/tp
LGTM but requires some changes to variable naming (can ctrl f to check)
zi-yii pushed 3 commits to master AY2425S1-CS2103-F12-1/tp
- Add tests in ParserUtilTest.java This commit adds test for parseInsurancePlan, parseClaimId and parseClaimAmount func... 7c40e18
- Change invalid claim amount to test 3 digit in cents 3706947
- Merge pull request #145 from matthewyip1511/matthew-update-parserUtilTest-CommandUtilTest Add tests in ParserUtilTest 5a4cce9
RezwanAhmed123 created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
sure, no worries
RezwanAhmed123 created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
yep that makes more sense, will change!
RezwanAhmed123 created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
that makes sense, good catch!
RezwanAhmed123 created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
no i was just being specific only, this shouldnt be an issue normally unless theres another object named the same within that local scope.
zi-yii created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
Can consider renaming the method to be more intuitive (raised in the above comment)
zi-yii created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
Instead of naming it as `execute_invalidClaim_exceptionHandled`, the method can be named as `execute_invalidClaim_throwsCommandException`. This would give an intuitive understanding of the test cas...
zi-yii created a review on a pull request on AY2425S1-CS2103-F12-1/tp
Just need to make changes to the naming of a few tests
zi-yii created a review on a pull request on AY2425S1-CS2103-F12-1/tp
Just need to make changes to the naming of a few tests
codecov[bot] created a comment on a pull request on AY2425S1-CS2103-F12-1/tp
## [Codecov](https://app.codecov.io/gh/AY2425S1-CS2103-F12-1/tp/pull/145?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=A...
codecov[bot] created a comment on a pull request on AY2425S1-CS2103-F12-1/tp
## [Codecov](https://app.codecov.io/gh/AY2425S1-CS2103-F12-1/tp/pull/146?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=A...
matthewyip1511 created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
Added this as I realised that there was no check for negative numbers. If the insurance Id entered is negative, it would still allow it to be parsed in the original form.
RezwanAhmed123 opened a pull request on AY2425S1-CS2103-F12-1/tp
Add method to check insurance commands and update some test methods.
Fix testing methods for Insurance and Claim Commands The testing utilities do not support comparison of states of InsurancePlansManager objects as we purposefully implemented it as a mutable o...
matthewyip1511 opened a pull request on AY2425S1-CS2103-F12-1/tp
Add tests in ParserUtilTest
Unlike the what the name of the branch says, this PR only adds tests for `ParserUtilTest` 🙂 the tests for `CommandUtilTest` will be added in a separate PR
zi-yii created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
Maybe using "client ID" would be better to follow how we write insurance id as "insurance ID" in javadoc
zi-yii created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
Did this cause any bugs? Would we need to make the same change for the other methods in InsurancePlansManager as well?