Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
yanqiyqh created a review on a pull request on AY2425S1-CS2103-F12-1/tp
Overall LGTM, just some clarifications
yanqiyqh created a review on a pull request on AY2425S1-CS2103-F12-1/tp
Overall LGTM, just some clarifications
github-actions[bot] pushed 1 commit to gh-pages AY2425S1-CS2103-F12-1/tp
- deploy: 665474cce5d121b72aee32dbf5989d76341c395c d53c1a8
RezwanAhmed123 pushed 11 commits to master AY2425S1-CS2103-F12-1/tp
- Add ability to select theme 7c4bd08
- Fix bug such to initialise user preferences for toggle 2bf8eeb
- Update LightTheme.css colours 506cee8
- Fix test error fde0492
- Fix checkstyle errors 2c9c8ee
- Merge branch 'master' into ziyi-add-toggle-theme-functionality f9c518a
- Add new line 0b3eb8a
- Abstract out toggling of theme fcbd40e
- Change variable access for messages a559db0
- Update getTheme method 1580b48
- Merge pull request #137 from zi-yii/ziyi-add-toggle-theme-functionality 665474c
RezwanAhmed123 closed a pull request on AY2425S1-CS2103-F12-1/tp
Add toggle theme function
Our app supports only a dark theme, which limits personalisation for users. Let's introduce a theme toggle functionality that allows users to switch between light and dark themes according to th...
codecov[bot] created a comment on a pull request on AY2425S1-CS2103-F12-1/tp
## [Codecov](https://app.codecov.io/gh/AY2425S1-CS2103-F12-1/tp/pull/138?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=A...
zi-yii opened a pull request on AY2425S1-CS2103-F12-1/tp
Add DeleteInsuranceCommandTest.java
There are no tests for DeleteInsuranceCommand.java. Let's add tests for DeleteInsuranceCommand to increase test coverage.
matthewyip1511 created a review on a pull request on AY2425S1-CS2103-F12-1/tp
Also, a (slightly) late message but I realised @yanqiyqh that this PR does not build which is causing it to fail the checks (beyond just the codecov coverage). So might want to check on that as wel...
zi-yii created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
Great suggestion, will make use of that!
yanqiyqh created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
I think having `public static final String THEME_CHANGE_MESSAGE = "Theme changed to %1$s mode.` will be a good way to abstract it out, as well as keeping our String formatting in line with our othe...
yanqiyqh created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
Thanks for pointing it out! Will add tests to cover it
zi-yii created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
oops, missed out on removing this
RezwanAhmed123 created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
Is there any significance behind this comment? Apologies, but I am having trouble understanding this.
RezwanAhmed123 created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
Is there a way to either abstract out the similar code, or handling this as a toggle? It seems like a lot of lines are being repeated, which may make maintenance difficult later. What do you think?
RezwanAhmed123 created a review on a pull request on AY2425S1-CS2103-F12-1/tp
LGTM, some minor code quality changes.
RezwanAhmed123 created a review on a pull request on AY2425S1-CS2103-F12-1/tp
LGTM, some minor code quality changes.
codecov[bot] created a comment on a pull request on AY2425S1-CS2103-F12-1/tp
## [Codecov](https://app.codecov.io/gh/AY2425S1-CS2103-F12-1/tp/pull/137?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=A...
zi-yii opened a pull request on AY2425S1-CS2103-F12-1/tp
Add toggle theme function
Our app supports only a dark theme, which limits personalisation for users. Let's introduce a theme toggle functionality that allows users to switch between light and dark themes according to th...