Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
RezwanAhmed123 closed a pull request on AY2425S1-CS2103-F12-1/tp
Update UserGuide for v1.4
Updated the userguide to add CloseClaimCommand, as well as fixing some bugs found after the last iteration (mainly regarding formatting errors).
codecov[bot] created a comment on a pull request on AY2425S1-CS2103-F12-1/tp
## [Codecov](https://app.codecov.io/gh/AY2425S1-CS2103-F12-1/tp/pull/132?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=A...
matthewyip1511 created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
Made non final so that we are able to modify this state to close the claim.
matthewyip1511 opened an issue on AY2425S1-CS2103-F12-1/tp
Update UserGuide for v1.4 features
Also to fix bugs identified along the way
codecov[bot] created a comment on a pull request on AY2425S1-CS2103-F12-1/tp
## [Codecov](https://app.codecov.io/gh/AY2425S1-CS2103-F12-1/tp/pull/130?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=A...
matthewyip1511 opened a pull request on AY2425S1-CS2103-F12-1/tp
Add CloseClaimCommand and CloseClaimCommandParser
Adding the `CloseClaimCommand` and `CloseClaimCommandParser` to support the close claim feature as listed in #85 and #88.
matthewyip1511 created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
This file LGTM
matthewyip1511 created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
likewise, should we write this as `otherInsurancePlanManager` ?
matthewyip1511 created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
Should we standardise this to `other` like we did in the `InsurancePlan` equals method?
matthewyip1511 created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
This part looks good to me 👍
matthewyip1511 created a review on a pull request on AY2425S1-CS2103-F12-1/tp
Suggested changes mentioned in the comments
matthewyip1511 created a review on a pull request on AY2425S1-CS2103-F12-1/tp
Suggested changes mentioned in the comments
codecov[bot] created a comment on a pull request on AY2425S1-CS2103-F12-1/tp
## [Codecov](https://app.codecov.io/gh/AY2425S1-CS2103-F12-1/tp/pull/129?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=A...
RezwanAhmed123 opened a pull request on AY2425S1-CS2103-F12-1/tp
Rezwan fix equals
Equals methods for Insurance Plans Manager, Insurance Plan and claims were updated. Client equals method was left alone as it raised too many issues when modified.
github-actions[bot] pushed 1 commit to gh-pages AY2425S1-CS2103-F12-1/tp
- deploy: f6e6e5f465293ac6cb1be2521a85407b0f85321e c86a383
matthewyip1511 pushed 2 commits to master AY2425S1-CS2103-F12-1/tp
matthewyip1511 closed a pull request on AY2425S1-CS2103-F12-1/tp
Fix the DeleteClaimCommandTest
I forgot to add the most important part, the deletion from the expected model...
codecov[bot] created a comment on a pull request on AY2425S1-CS2103-F12-1/tp
## [Codecov](https://app.codecov.io/gh/AY2425S1-CS2103-F12-1/tp/pull/128?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=A...
RezwanAhmed123 opened a pull request on AY2425S1-CS2103-F12-1/tp
Fix the DeleteClaimCommandTest
I forgot to add the most important part, the deletion from the expected model...
github-actions[bot] pushed 1 commit to gh-pages AY2425S1-CS2103-F12-1/tp
- deploy: 3fb2bf36b773d91cd5f13f41ddb9ff85c2501950 44d453f
matthewyip1511 pushed 2 commits to master AY2425S1-CS2103-F12-1/tp
matthewyip1511 closed a pull request on AY2425S1-CS2103-F12-1/tp
Fix test for DeleteClaimCommand.java
Some weird behaviours only found during the testing phase. The persisting issue is that the models point to the same insurance plan manager object when manipulating one of the models. In the act...
matthewyip1511 created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
Makes sense. Thanks! Going to merge now
RezwanAhmed123 created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
yeah is to fix the tests better also because if u create before deleting, the message is gonna be different if u take the formatted client message (which includes all the info including plans and c...
matthewyip1511 created a review comment on a pull request on AY2425S1-CS2103-F12-1/tp
Just to be clear: this is not to fix the current issue right, but more to address the issue that surfaced over the weekend in our telegram chat 🙂