Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
goran-ethernal pushed 1 commit to feat/agg-sender 0xPolygon/cdk
- fix: remove saveCertificate to json function 505a02c
vcastellm created a review comment on a pull request on 0xPolygon/cdk
This should be enough ```suggestion echo >> $_TMP_FILE ```
vcastellm created a review comment on a pull request on 0xPolygon/cdk
And this is why files should always end in new line 😁
vcastellm created a review comment on a pull request on 0xPolygon/cdk
Can I run without the agglayer? in other words, is this conditional with setting `SettlementBackend` in the aggregator?
vcastellm created a review comment on a pull request on 0xPolygon/cdk
not related to this PR but prover here?
vcastellm created a review comment on a pull request on 0xPolygon/cdk
Is this test necessary?
vcastellm created a review comment on a pull request on 0xPolygon/cdk
INTs in SQLite are 64 bit size so they are the same supported size as Postgres BIGINT, better to switch to INT?
vcastellm created a review comment on a pull request on 0xPolygon/cdk
Weird... is it a benefit to store this in strings and do the parsing on the app side? I'd say it's better to do this https://stackoverflow.com/a/40435685
vcastellm created a review comment on a pull request on 0xPolygon/cdk
This could be renamed to StoragePath for consistency with other components, we can use this PR for that maybe?
sonarcloud[bot] created a comment on a pull request on 0xPolygon/cdk
## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=...
goran-ethernal pushed 1 commit to feat/agg-sender 0xPolygon/cdk
- feat: GetBridgesPublished unit test d47cb01