Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
goran-ethernal pushed 1 commit to feat/agg-sender 0xPolygon/cdk
- fix: remove execution clients df721ec
goran-ethernal pushed 15 commits to feat/agg-sender 0xPolygon/cdk
- test: L2 to L1 withdrawal bc38b5e
- test: increase timeout a5791ed
- Merge branch 'develop' into vcastellm/withdrawal-e2e d0e5501
- refactor: remove functions and test withdrawal 718cd96
- refactor: fixes c86e3b8
- ci: adjust timeout 9a76640
- ci: timeout and pless 3805e8a
- refactor: apply feedback 7029ba5
- ci: bump prover d740003
- ci: try something 213139e
- ci: try 899210c
- ci: peek at bridge file 2098a6b
- ci: upload logs f90062e
- Merge commit 'f90062e95b8654707a2052bf3b9fd26a3e0b77f4' into feat/agg-sender e81c6c1
- fix: remove execution clients b3ab35d
joanestebanr created a review comment on a pull request on 0xPolygon/cdk
The `fromBlock` is the block of last certificate + 1, so the case that you say the next certificate will start with **22+1**
goran-ethernal created a review comment on a pull request on 0xPolygon/cdk
The change on the bridge syncer db to store big int as TEXT was made because the sqlite kept saving big numbers with scientific annotation, for example if you have 810.000.000 it will save it as 8....
goran-ethernal created a review comment on a pull request on 0xPolygon/cdk
I agree, but the only endpoint the `agglayer` has in `getCertificateHeader` which gets the certificate by its hash. If we don't have anything in our db, then there is no way to know what was last s...
goran-ethernal created a review comment on a pull request on 0xPolygon/cdk
We will continue building certificate if we don't have claims (`len() == 0`). We are protecting our selves from block not processed in `toBlock, err := chooseToL2Block(lastL2Block.Number.Uint64(), ...
goran-ethernal created a review comment on a pull request on 0xPolygon/cdk
When you've processed blocks but don't have any bridges in them.
sonarcloud[bot] created a comment on a pull request on 0xPolygon/cdk
## [](https://sonarcloud.io/dashboard?id=...
arnaubennassar pushed 1 commit to feat/doc-non-evm-integration 0xPolygon/cdk
- Apply suggestions from code review Co-authored-by: Dra Murphy <[email protected]> 01559bf
sonarcloud[bot] created a comment on a pull request on 0xPolygon/cdk
## [](https://sonarcloud.io/dashboard?id=...
arnaubennassar pushed 1 commit to feat/doc-non-evm-integration 0xPolygon/cdk
- Update docs/SUMMARY.md Co-authored-by: Dra Murphy <[email protected]> 7ec15b8
arnaubennassar created a review comment on a pull request on 0xPolygon/cdk
shouldnt `certificate_id` be enough for a primary key?
arnaubennassar created a review comment on a pull request on 0xPolygon/cdk
I dont get this part, I thought it would be something like: - if we have a last sent cert on the DB, return that (prolly after asserting that what we have is consistent with the aggLayer) - else,...
arnaubennassar created a review comment on a pull request on 0xPolygon/cdk
prolly a good idea to check if we've sent some cert that is still pending and return false if so
arnaubennassar created a review comment on a pull request on 0xPolygon/cdk
If I understood things well, wen we do the `getLastSentCertificateData` we relay on the LER for linking to a block number. So I guess that we should be consistent here. Otherwise we could send clai...
arnaubennassar created a review comment on a pull request on 0xPolygon/cdk
same comment as the potential error not found as before, in this case that would be bad, as it's acceptable to not have claims and so we should proceed with the execution
arnaubennassar created a review comment on a pull request on 0xPolygon/cdk
not sure how the len() == 0 is returned, maybe it's with the form of an error not found
arnaubennassar created a review comment on a pull request on 0xPolygon/cdk
we should avoid using a execution client in the aggSender. Doing so will couple the aggSender with the execution client, something that we want to avoid to keep thing modular. Basically having EVM ...
sonarcloud[bot] created a comment on a pull request on 0xPolygon/cdk
## [](https://sonarcloud.io/dashboard?id=...
ToniRamirezM pushed 1 commit to feature/GHAUploadLogs 0xPolygon/cdk
- feat: update logs for e2e tests c66bb03
sonarcloud[bot] created a comment on a pull request on 0xPolygon/cdk
## [](https://sonarcloud.io/dashboard?id=...
ToniRamirezM pushed 1 commit to feature/GHAUploadLogs 0xPolygon/cdk
- feat: update logs for e2e tests bc807ed