Ecosyste.ms: Timeline

Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.

jlkravitz

jlkravitz created a review on a pull request on csg-org/CompactConnect

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Where is this diagram located?

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
If you wanted it to run at noon UTC-4, wouldn't hour be set to `8`?

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
I'm a bit confused by this comment. What does this mean, and what are its implications for the code in this file?

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
What distinguishes this code from the setup code that's been abstracted away into `_when_purchase_client_returns_transactions`, etc?

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
What's the purpose of passing this list into this function?

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
```suggestion # we'll have to allow the principal to use any SES identity configured in the account. ```

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
Is there a way to organize the json files a little differently so we can avoid this one-off case?

View on GitHub

jlkravitz created a review comment on a pull request on csg-org/CompactConnect
What about the case where `FROM_ADDRESS` is not defined at all?

View on GitHub

jlkravitz created a review on a pull request on csg-org/CompactConnect
Lookin' good. A few small comments/questions/nits. Hope you had a nice holiday and new year!

View on GitHub

jlkravitz created a review on a pull request on csg-org/CompactConnect
Lookin' good. A few small comments/questions/nits. Hope you had a nice holiday and new year!

View on GitHub