Ecosyste.ms: Timeline
Browse the timeline of events for every public repo on GitHub. Data updated hourly from GH Archive.
JeroenDeDauw pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Update PHPStan baseline 5cbd6a2
JeroenDeDauw pushed 5 commits to master ProfessionalWiki/WikibaseFacetedSearch
JeroenDeDauw closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Making naming consistent
Partially a follow up to * https://github.com/ProfessionalWiki/WikibaseFacetedSearch/pull/127 We now have * `InstanceOf id` for the property IDs * `item type` for the values (item IDs) `In...
JeroenDeDauw created a comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Rebased and fixed the renames I missed
JeroenDeDauw pushed 1 commit to naming ProfessionalWiki/WikibaseFacetedSearch
- Rename renaming instance of InstanceType(Id) ac01f5d
JeroenDeDauw pushed 4 commits to naming ProfessionalWiki/WikibaseFacetedSearch
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
If the string are a bunch longer than perhaps a solution like that becomes worthwhile. Currently seems like a net negative
alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Should we rename `$instanceTypeExtractor` to `$itemTypeExtractor`?
alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Should we rename `newInstanceTypeExtractor()` too?
JeroenDeDauw closed an issue on ProfessionalWiki/WikibaseFacetedSearch
Rewrite Page search result link text
Follow-up to https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/4 Related refactor: https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/75 Initially we rewrote only...
JeroenDeDauw pushed 1 commit to master ProfessionalWiki/WikibaseFacetedSearch
- Refactor search result title rewrite (#113) * Refactor search result title rewrite * Simplify condition by flippi... a830a23
JeroenDeDauw closed an issue on ProfessionalWiki/WikibaseFacetedSearch
Clean up onShowSearchHitTitle
And the private static functions it uses: * getItemId, * rewriteLinkForNonEntityResult * termFallbackToTermData AC: * Logic in instance scope (unless reason to deviate) * Logic tested (unl...
JeroenDeDauw closed a pull request on ProfessionalWiki/WikibaseFacetedSearch
Refactor search result title rewrite
Fixes https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/75 and https://github.com/ProfessionalWiki/WikibaseFacetedSearch/issues/94 * Removes the old code for rewriting an Item sea...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Does this question still matter? I cannot find the code in the latest diff
alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
That works too. On a side note, would it be more readable if the query string is broken down into an array and join together as a string?
JeroenDeDauw pushed 5 commits to search-title ProfessionalWiki/WikibaseFacetedSearch
alistair3149 created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I thought we have to replicate the constructor like the original class for tests. Is simplification without the Config acceptable?
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
I find this more readable than using a constant. By proving the ID in the line above, it is obvious what the expected ID is, and the query remains easy to read.
codecov-commenter created a comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
## [Codecov](https://app.codecov.io/gh/ProfessionalWiki/WikibaseFacetedSearch/pull/131?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comme...
JeroenDeDauw created a review comment on a pull request on ProfessionalWiki/WikibaseFacetedSearch
Unsure why we built a Config just to get the ID